Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: made the inferrence of minor constituents an option #272

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Conversation

tsutterley
Copy link
Owner

@tsutterley tsutterley commented Jan 17, 2024

refactor: 1-liners in compute.py
refactor: lunisolar ephemerides functions
feat: added more constituent parameters for OTIS/ATLAS predictions
fix: add option to return None and not raise error for Doodson numbers
docs: add more definitions to the glossary
refactor: moved constituent parameters function from predict to arguments
feat: add functions for tide generating forces and potentials
fix: variable typing for c in _constituent_parameters
test: omit deprecated functions in coverage report

refactor: lunisolar ephemerides functions
feat: added more constituent parameters for OTIS/ATLAS predictions
fix: add option to return None and not raise error for Doodson numbers\
docs: add more definitions to the glossary
…ents

feat: add functions for tide generating forces and potentials
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 448 lines in your changes are missing coverage. Please review.

Comparison is base (ab6eefc) 70.50% compared to head (f4bee55) 70.77%.
Report is 5 commits behind head on main.

Files Patch % Lines
pyTMD/compute.py 27.22% 271 Missing and 31 partials ⚠️
pyTMD/solve.py 40.54% 40 Missing and 4 partials ⚠️
pyTMD/arguments.py 88.48% 18 Missing and 14 partials ⚠️
pyTMD/crs.py 70.47% 30 Missing and 1 partial ⚠️
pyTMD/astro.py 72.72% 5 Missing and 4 partials ⚠️
pyTMD/io/constituents.py 69.23% 8 Missing ⚠️
pyTMD/constants.py 12.50% 4 Missing and 3 partials ⚠️
pyTMD/predict.py 84.00% 1 Missing and 3 partials ⚠️
pyTMD/io/model.py 25.00% 3 Missing ⚠️
pyTMD/io/FES.py 60.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   70.50%   70.77%   +0.27%     
==========================================
  Files          43       41       -2     
  Lines        9068     9518     +450     
  Branches     1197     1259      +62     
==========================================
+ Hits         6393     6736     +343     
- Misses       2317     2397      +80     
- Partials      358      385      +27     
Flag Coverage Δ
unittests 70.77% <63.18%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test: add quick test for currents wrapper function
@tsutterley tsutterley merged commit 796d34c into main Jan 18, 2024
3 of 4 checks passed
@tsutterley tsutterley deleted the dev branch January 18, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant